This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Replace inner html #108
Open
Replace inner html #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geändert: src/util/createNav.js
geändert: src/util/createList.js geändert: test/tests/util/createList.test.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed list creation. Replaced innerHTML with appendChild().
Changes made in createList, createNav and createList.test.
Reason: Get the script running with a Content-Security-Policy Header: require-trusted-types-for 'script' and no policy for scrollnav
Seems to work fine, all tests pass. This patch shouldn't have changed the behaviour of scrollnav at all.
Can't get codepen to load the external ressource from github. Working demo: aequometer.de